RFR: 8307348 - Parallelize heap walk for ObjectCount(AfterGC) JFR event collection [v7]
olivergillespie
duke at openjdk.org
Mon May 8 16:39:30 UTC 2023
On Mon, 8 May 2023 08:18:46 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Sorry, I don't think I understand the suggestion. Are you suggesting to use WithActiveWorkers only for the heap inspection VM op, and workers->active_workers() everywhere else (for the collector use-case)?
>>
>>> The problem is that one heap inspection VM operation. Maybe put the WithActiveWorkers there
>>
>> This area *is* that one heap inspection VM operation, isn't it?
>
> You are right, I misread the code. Ignore my comment :) Ship it.
Cool, thanks for reviewing :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13774#discussion_r1187650940
More information about the hotspot-gc-dev
mailing list