RFR: 8307518: Remove G1 workaround in jstat about zero sized generation sized

Kim Barrett kbarrett at openjdk.org
Wed May 10 11:06:17 UTC 2023


On Tue, 9 May 2023 07:50:54 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review removal of some workaround in g1 memory usage monitoring that made sure that there were no 0-sized generations in the output. After [JDK-8307428](https://bugs.openjdk.org/browse/JDK-8307428) this is not necessary any more.
> 
> Testing: tier1-5
> 
> Thanks,
>   Thomas

Looks good.  Just some weird pre-existing formatting that could be dealt with now or later.

src/hotspot/share/gc/g1/g1MonitoringSupport.cpp line 141:

> 139:     "space", 0 /* ordinal */,
> 140:     g1h->max_capacity() /* max_capacity */,
> 141:     _old_gen_committed /* init_capacity */);

[pre-existing] The indentation of all these HSpaceCounters constructor calls is pretty unusual.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13880#pullrequestreview-1420374919
PR Review Comment: https://git.openjdk.org/jdk/pull/13880#discussion_r1189741928


More information about the hotspot-gc-dev mailing list