RFR: 8305898: Alternative self-forwarding mechanism [v10]

[Roman Kennke]

On Thu, 11 May 2023 08:00:53 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8305896' into JDK-8305898
>>  - Align fake-heap without GCC warnings (duh)
>
> src/hotspot/share/oops/oop.inline.hpp line 276:
> 
>> 274: }
>> 275: 
>> 276: void oopDesc::forward_failed() {
> 
> It is a bit confusing that oopDesc::forward_failed is a setter, while markWord::forward_failed is a getter.

Yeah.
It's even more confusing that we now have the notion of forward-failed, which aims to hide the implementation detail of self-forwarding, but forwardee() still exposes it. And probably has to, because that is how the forwarding logic of GCs currently work, and I'm not sure it is useful to change that. I need to mull over this a bit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13779#discussion_r1190843704