RFR: 8306541: Refactor collection set candidate handling to prepare for JDK-8140326 [v11]

Thu May 11 15:29:54 UTC 2023

On Thu, 11 May 2023 14:29:26 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed assert that is useless for now
>
> src/hotspot/share/gc/g1/g1CollectionSetCandidates.hpp line 173:
> 
>> 171: 
>> 172:   // The number of regions from the last merge of candidates from the marking.
>> 173:   uint _last_marking_candidates_length;
> 
> Looking at how it is used, I wonder if we can record `min_old_cset_length`, which is what is actually needed.

I would like to defer this suggestion (which is good) as this is an improvement of the existing code which I would like to follow here for this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13666#discussion_r1191352822