RFR: 8305896: Alternative full GC forwarding [v32]

Roman Kennke rkennke at openjdk.org
Tue May 16 17:08:09 UTC 2023


On Tue, 16 May 2023 16:54:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/slidingForwarding.hpp line 159:
>> 
>>> 157:  * is sufficient because G1 serial compaction is single-threaded.
>>> 158:  */
>>> 159: class FallbackTable : public CHeapObj<mtGC>{
>> 
>> Could this class be placed inside `SlidingForwarding` for better encapsulation?
>
> Why do you write your own hashtable when there's one in utilities/resourceHash.hpp ? there's a put_when_absent() function that is similar than this insert function and faster than put_if_absent().

Uh, I've not been aware of it and somehow haven't found it when I searched for something like it. resourceHash.hpp perhaps wasn't a name that struck me as a generic hashtable impl. :-) Let me check if it's feasible to just use the one in resourceHash.hpp

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13582#discussion_r1195460418


More information about the hotspot-gc-dev mailing list