RFR: 8308097: Generational ZGC: Update constructor syntax

Kim Barrett kbarrett at openjdk.org
Wed May 17 03:42:53 UTC 2023


On Tue, 16 May 2023 12:59:11 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> > Is this something that should be in the style guide? Presumably we have constructors all through the hotspot code that may not conform to this style.
> 
> ZGC has a much stricter code style than the rest of HotSpot. Previous attempts to drive style guide questions have been quite disappointing (at least to me), so we've carved out our own corner in HotSpot where we try to keep the code uniform.

As @stefank said, ZGC has a stricter style, making choices in some areas where
there doesn't seem to be universal (or even widespread) agreement and usage.
Constructor style is one of those areas - we're all over the place here, with
some styles seeming quite bad to some people. That said, while I personally
didn't care for the prior ZGC constructor style (it requires non-default emacs
configuration), this new one is what I would prefer if we were going to mandate
something.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13987#issuecomment-1550647114


More information about the hotspot-gc-dev mailing list