RFR: 8308231: Faster MemAllocator::Allocation checks for verify/notification [v2]

Aleksey Shipilev shade at openjdk.org
Mon May 22 17:57:55 UTC 2023


On Mon, 22 May 2023 10:44:52 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Touch up comment
>>  - Merge branch 'master' into JDK-8308231-memalloc-check-faster
>>  - Hide more stuff
>>  - Touchups
>>  - Branch
>>  - Fix
>
> src/hotspot/share/gc/shared/memAllocator.cpp line 106:
> 
>> 104:       if (should_notify_allocation()) {
>> 105:         notify_allocation(_thread);
>> 106:       }
> 
> `notify_allocation` used to call   `notify_allocation_low_memory_detector` and `notify_allocation_dtrace_sampler` without performing any "should notify" filtering. Is this change in behavior intentional?

Not really, but I wonder if we actually need to do these for inside-TLAB allocs. I think I'll go the way Albert leans, and see what happens here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14019#discussion_r1200845220


More information about the hotspot-gc-dev mailing list