RFR: 8318706: Implement JEP 423: Region Pinning for G1 [v9]
Stefan Johansson
sjohanss at openjdk.org
Wed Nov 8 14:49:00 UTC 2023
On Fri, 3 Nov 2023 14:14:36 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Parsing the separate components is easier :) Not sure if these tags in any way ever indicated some level of abstraction.
>>
>> I do not have a strong opinion here. The combinations
>>
>> (Pinned)
>> (Allocation Failure)
>> (Pinned + Allocation Failure) // or the other way around, or some other symbol for "+" or no symbol at all?
>>
>> are fine with me (and I thought about doing something more elaborate here), but my concern has been that any complicated string makes it less unique (e.g. `(Allocation Failure)` vs. "Allocation Failure") and adds code both to implement and parse the result.
>>
>> Much more disrupting is likely that there is no "Evacuation Failure" string any more. But log messages are not part of the external interface, and we should not want to change them just because.
>
> The example looks good to me.
Have the final output looking something like this was agreed on during internal discussion:
GC(6) Pause Young (Normal) (Evacuation Failure: Pinned) 1M->1M(22M) 36.16ms
GC(6) Pause Young (Normal) (Evacuation Failure: Allocation) 1M->1M(22M) 36.16ms
GC(6) Pause Young (Normal) (Evacuation Failure: Allocation / Pinned) 1M->1M(22M) 36.16ms
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16342#discussion_r1386736860
More information about the hotspot-gc-dev
mailing list