RFR: JDK-8234502 : Merge GenCollectedHeap and SerialHeap [v6]

[Albert Mingkun Yang]

On Wed, 15 Nov 2023 14:32:49 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:

>> JDK-8234502 : Merge GenCollectedHeap and SerialHeap
>
> Lei Zaakjyu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix include statements

src/hotspot/share/gc/serial/serialHeap.cpp line 94:

> 92: 
> 93: SerialHeap::SerialHeap() :
> 94: #if 0

Isn't this effectively dead code?

src/hotspot/share/gc/serial/serialVMOperations.hpp line 66:

> 64: 
> 65: 
> 66: #endif // SHARE_GC_SERIAL_SERIALVMOPERATIONS_HPP

I think it misses a line-break for EOF, which is why this special icon shows here. (The same issue exists in some other files updated by this PR as well.)

src/hotspot/share/gc/shenandoah/shenandoahMonitoringSupport.hpp line 29:

> 27: 
> 28: #include "memory/allocation.hpp"
> 29: #include "gc/shared/collectorCounters.hpp"

If this is required, could it be made in its own PR? It's odd to see this PR changes files exclusively owned by other collectors.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16623#discussion_r1395875545
PR Review Comment: https://git.openjdk.org/jdk/pull/16623#discussion_r1395878314
PR Review Comment: https://git.openjdk.org/jdk/pull/16623#discussion_r1395869900