RFR: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification [v2]

[Thomas Schatzl]

On Wed, 22 Nov 2023 11:10:54 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>I don't believe this API should be part of this class. It appears entirely caller-specific,

All of these `_for_full_gc`/`_after_full_gc` methods (and `note_*_marking/scrubbing` methods for concurrent mark) are caller specific, for exactly one caller, for a particular situation the caller encounters. Is there something particularly problematic with this exact method compared to others?

> and it's unclear why the implementation is just a field-update without knowledge of the caller context. While the comment helps mitigate the situation, making it acceptable for a bugfix, I think it would be more appropriate to relocate methods related to parsable-bottom outside of this class.

So basically `_parsable_bottom` (and `_top_at_mark_start` since it is very similar to PB) fields should be somewhere else then? I think there is a CR for moving TAMS somewhere else, there is nothing for PB.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16733#discussion_r1401918339