RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v47]

Stefan Johansson sjohanss at openjdk.org
Thu Nov 23 08:51:20 UTC 2023


On Wed, 22 Nov 2023 23:08:36 GMT, Jonathan Joo <jjoo at openjdk.org> wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanup and address comments

I think this looks good now. I've started some additional testing to make sure we don't run into anything unexpected with the newly added test on any platforms. 

Will approve once the testing is green.

src/hotspot/share/runtime/cpuTimeCounters.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2002, 2023, Oracle and/or its affiliates. All rights reserved.

This is probably on me, but this 2002 is wrong:
Suggestion:

 * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15082#pullrequestreview-1745951725
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1403070166


More information about the hotspot-gc-dev mailing list