Integrated: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass

Thomas Schatzl tschatzl at openjdk.org
Tue Nov 28 20:58:19 UTC 2023


On Tue, 21 Nov 2023 16:01:39 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this fix that removes the access to a partially unloaded (i.e. unlinked only) `Klass` used for debug code in `G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes`.
> 
> This starts to fail if metadata purging happens before the call to this methods (as https://bugs.openjdk.org/browse/JDK-8317809 suggests). The test gc/g1/humongousObjects/TestHumongousClassLoader.java starts to crash on linux-x86 with 100% reproduction because it more aggressively uncommits memory when purging metaspace.
> 
> The fix fixes the asserts to only access the klass when it should not be unloaded yet.
> 
> Testing: failing test case not failing any more, gha
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: 21d361e9
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/21d361e944a599e82e5ed93aa81ad485b4601843
Stats:     10 lines in 1 file changed: 0 ins; 7 del; 3 mod

8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass

Reviewed-by: ayang, iwalulya

-------------

PR: https://git.openjdk.org/jdk/pull/16766


More information about the hotspot-gc-dev mailing list