RFR: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm [v2]

Leo Korinth lkorinth at openjdk.org
Fri Oct 13 12:26:46 UTC 2023


On Fri, 13 Oct 2023 10:01:50 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add @key flag-sensitive
>
> test/hotspot/jtreg/gc/arguments/TestG1HeapSizeFlags.java line 29:
> 
>> 27:  * @test TestG1HeapSizeFlags
>> 28:  * @bug 8006088
>> 29:  * @requires vm.gc.G1 & vm.opt.x.Xmx == null & vm.opt.x.Xms == null & vm.opt.MinHeapSize == null & vm.opt.MaxHeapSize == null & vm.opt.InitialHeapSize == null
> 
> Please move the requires below the @key to be consistent with the other tests.

will do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15986#discussion_r1358183735


More information about the hotspot-gc-dev mailing list