RFR: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm [v4]
Leo Korinth
lkorinth at openjdk.org
Mon Oct 16 10:34:22 UTC 2023
On Mon, 16 Oct 2023 09:50:59 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add flag-sensitive key to TEST.ROOT
>
> test/hotspot/jtreg/TEST.ROOT line 35:
>
>> 33: # randomness: test uses randomness, test cases differ from run to run
>> 34: # cgroups: test uses cgroups
>> 35: keys=stress headful intermittent randomness cgroups flag-sensitive
>
> Maybe add a comment above about the key, similar to the others. Something like:
>
> # flag-sensitive: test is sensitive to certain flags and might fail when flags are passed in
Thanks, I reworded it just slightly
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15986#discussion_r1360426624
More information about the hotspot-gc-dev
mailing list