RFR: 8317358: G1: Make TestMaxNewSize use createTestJvm
Leo Korinth
lkorinth at openjdk.org
Mon Oct 16 11:52:49 UTC 2023
On Mon, 2 Oct 2023 15:09:49 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
> In addition remove deprecated `Long(long)` constructor and rewrite `compareTo` to use `> 0` instead of `== 1`.
>
> Also remove unused `isRunningG1(String[] args)` and `checkIncompatibleNewSize(String[] flags)`
>
> Minimal testing completed, will run tier testing before pushing.
I want to just give a few clarifications:
`isRunningG1(String[] args)` that I removed was not really useful from what I understand; the resulting heap region size would always be a 32M (ergonomic max) or less resulting in a successful test run, however when we propagate flags it *will* make a difference.
I could add that code back, and I could add `@require` lines for `-Xmn` etc. I think what would be best though is to ignore all possible breaking flags and just add `flag-sensetive`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16012#issuecomment-1764301136
More information about the hotspot-gc-dev
mailing list