RFR: 8317358: G1: Make TestMaxNewSize use createTestJvm [v2]
Thomas Schatzl
tschatzl at openjdk.org
Wed Oct 18 10:02:39 UTC 2023
On Tue, 17 Oct 2023 11:53:54 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> In addition remove deprecated `Long(long)` constructor and rewrite `compareTo` to use `> 0` instead of `== 1`.
>>
>> Also remove unused `isRunningG1(String[] args)` and `checkIncompatibleNewSize(String[] flags)`
>>
>> Minimal testing completed, will run tier testing before pushing.
>
> Leo Korinth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - @key flag-sensitive
> - Merge branch '_master_jdk' into _8317358
> - 8317358: G1: Make TestMaxNewSize use createTestJvm
Similar to @kstefanj I am a bit doubtful to have a test that is needs constraints on heap size to run with any random flags. This can be seen on the very long list of @requires constraints.
But I am good with doing this experiment and see if it will be annoying enough or not to reconsider.
-------------
Marked as reviewed by tschatzl (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16012#pullrequestreview-1684635185
More information about the hotspot-gc-dev
mailing list