RFR: 8318507: G1: Improve remset clearing for humongous candidates

Ivan Walulya iwalulya at openjdk.org
Thu Oct 19 18:03:38 UTC 2023


On Thu, 19 Oct 2023 15:29:08 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this small cleanup that merges two calls to `HeapRegionRemSet::clear()/HeapRegionRemSet::set_state_complete()` to a single call to `clear()` with appropriate parameters.
> 
> Also remove now obsolete asserts that are done in `clear()` already; actually the second one is wrong, there may be code roots attached to the region.
> 
> Testing: gha, tier1-5 almost done
> 
> Thanks,
>   Thomas

LGTM!

-------------

Marked as reviewed by iwalulya (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16270#pullrequestreview-1688267191


More information about the hotspot-gc-dev mailing list