RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v23]

Richard Reingruber rrich at openjdk.org
Fri Oct 20 05:48:49 UTC 2023


On Thu, 19 Oct 2023 13:51:10 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 36 additional commits since the last revision:
>> 
>>  - Use better name: _preprocessing_active_workers
>>  - Merge branch 'master'
>>  - Remove obsolete comment
>>  - Feedback Albert
>>  - Merge branch 'master'
>>  - Re-cleanup (was accidentally reverted)
>>  - Make sure to scan obj reaching in just once
>>  - Simplification suggested by Albert
>>  - Don't overlap card table processing with scavenging for simplicity
>>  - Cleanup
>>  - ... and 26 more: https://git.openjdk.org/jdk/compare/355d3adc...f7965512
>
> src/hotspot/share/gc/parallel/psCardTable.hpp line 91:
> 
>> 89:       return end;
>> 90:     }
>> 91:   };
> 
> Could these implementations moved into the .cpp file? They are only every referenced by that and should be inlined anyway to not clog the interface/hpp file too much.

Moved the class StripeShadowTable to psCardTable.cpp (and renamed it).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14846#discussion_r1366499415


More information about the hotspot-gc-dev mailing list