RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v24]

Richard Reingruber rrich at openjdk.org
Fri Oct 20 05:55:40 UTC 2023


On Thu, 19 Oct 2023 14:37:06 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   preprocess_card_table_parallel should be private
>
> src/hotspot/share/gc/parallel/psCardTable.cpp line 242:
> 
>> 240:   SpinYield spin_yield;
>> 241:   while (Atomic::load_acquire(&_preprocessing_active_workers) > 0) {
>> 242:     spin_yield.wait();
> 
> I would prefer to have the synchronization as part of `scavenge_contents_parallel`; i.e. the logic there being
> 
> Prepare Scavenge
> Synchronize
> Scavenge
> 
> Here the synchronization feels out of place and surprising for a method that nowhere indicates that it is doing anything other than preprocessing the table.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14846#discussion_r1366503671


More information about the hotspot-gc-dev mailing list