RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v28]

Richard Reingruber rrich at openjdk.org
Fri Oct 20 13:13:50 UTC 2023


On Fri, 20 Oct 2023 09:36:34 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup/improve comments
>
> src/hotspot/share/gc/parallel/psCardTable.cpp line 216:
> 
>> 214:   // The "shadow" table is a copy of the card table entries of the current stripe.
>> 215:   // It is used to separate card reading, clearing and redirtying which reduces
>> 216:   // complexity significantly.
> 
> That would be a perfect comment to put just before the `ShadowCardTable` class definition. Not seeing the point of putting this at the place we instantiate it.

I will move the comment to the decl. of `PSStripeShadowCardTable`.
I put it in `PSCardTable::process_range` because `PSStripeShadowCardTable` feels like an implementation detail of it. I'd move the whole class there if it wasn't too big.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14846#discussion_r1366956932


More information about the hotspot-gc-dev mailing list