RFR: 8318507: G1: Improve remset clearing for humongous candidates

Albert Mingkun Yang ayang at openjdk.org
Mon Oct 23 07:22:34 UTC 2023


On Thu, 19 Oct 2023 15:29:08 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> actually the second one is wrong, there may be code roots attached to the region.

`occupancy_less_or_equal_than` should have ensured that code-roots is empty. (The method name is not very obvious on that, IMO. Breaking it into two might be better.) I believe one can `assert(r->rem_set()->is_complete() && r->rem_set()->is_empty(), "inv");` after `clear(...)`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16270#issuecomment-1774574130


More information about the hotspot-gc-dev mailing list