RFR: 8318507: G1: Improve remset clearing for humongous candidates [v2]
Hamlin Li
mli at openjdk.org
Mon Oct 23 07:47:31 UTC 2023
On Mon, 23 Oct 2023 07:43:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this small cleanup that merges two calls to `HeapRegionRemSet::clear()/HeapRegionRemSet::set_state_complete()` to a single call to `clear()` with appropriate parameters.
>>
>> Also remove now obsolete asserts that are done in `clear()` already; actually the second one is wrong, there may be code roots attached to the region.
>>
>> Testing: gha, tier1-5 almost done
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> add assert
LGTM.
-------------
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16270#pullrequestreview-1691896341
More information about the hotspot-gc-dev
mailing list