RFR: 8318629: G1: Refine code a bit in G1RemSetTrackingPolicy::update_at_allocate [v2]

[Thomas Schatzl]

On Mon, 23 Oct 2023 14:37:59 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this simple refactoring?
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refine code

Fwiw, the original intent of the existing code structure has been to be _very_ obvious and clear with what happens to which region to avoid mistakes.

Imo this change makes the code more clear, but if more people think it does not matter I'm not opposed to it.

src/hotspot/share/gc/g1/g1RemSetTrackingPolicy.cpp line 49:

> 47:   }
> 48:   // Always collect remembered set for young regions.
> 49:   // Collect remembered sets for humongous regions by default to allow eager reclaim.

Suggestion:

  // Always collect remembered set for young regions and for humongous regions. Humongous regions need that for eager reclaim.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16300#pullrequestreview-1696671890
PR Review Comment: https://git.openjdk.org/jdk/pull/16300#discussion_r1371343740