RFR: 8318647: Serial: Refactor BlockOffsetTable
Thomas Schatzl
tschatzl at openjdk.org
Wed Oct 25 11:01:45 UTC 2023
On Wed, 25 Oct 2023 10:54:25 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> The diff is too large; maybe it's better to read the new impl directly, which I believe is much easier to follow.
>>
>> There is some duplication with G1's implementation, which should probably be dealt with in its own PR.
>
> src/hotspot/share/gc/serial/serialBlockOffsetTable.cpp line 84:
>
>> 82: }
>> 83:
>> 84: // Write the backskip value for each region.
>
> Suggestion:
>
> // Write the backskip value for the given region.
Note that region isn't defined very exactly. Here it is (apparently) the memory from `blk_start` to `blk_end`, but later it is also used as "area containing the same backskip value". Maybe there is some better wording to be found.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16304#discussion_r1371544873
More information about the hotspot-gc-dev
mailing list