RFR: 8318647: Serial: Refactor BlockOffsetTable [v2]

[Thomas Schatzl]

On Wed, 25 Oct 2023 11:18:10 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/serial/serialBlockOffsetTable.hpp line 43:
>> 
>>> 41: // systems using card-table-based write barriers, the efficiency of this
>>> 42: // operation may be important.  Implementations of the BlockOffsetTable
>>> 43: // class may be useful in providing such efficient implementations.
>> 
>> The comment is completely outdated, talking about subtypes where there are none any more of this class.
>
> I think the subtypes refer to heaps from different collectors. Not sth around `BlockOffsetArray`.

Still it isn't worth (and somewhat confusing) imo to talk about subtypes when there are none, particularly because the change deleted the comment about subtypes below.

>> src/hotspot/share/gc/serial/serialBlockOffsetTable.hpp line 45:
>> 
>>> 43: // class may be useful in providing such efficient implementations.
>>> 44: 
>>> 45: class BlockOffsetSharedArray: public CHeapObj<mtGC> {
>> 
>> Should be prefixed by `Serial`, same as `BlockOffsetTable` (since this is a complete reimplementation anyway).
>
> Maybe this renaming can be done in its own (trivial) PR for easier reviewing.

sure np.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16304#discussion_r1371633574
PR Review Comment: https://git.openjdk.org/jdk/pull/16304#discussion_r1371634485