RFR: 8318647: Serial: Refactor BlockOffsetTable [v2]

Thomas Schatzl tschatzl at openjdk.org
Wed Oct 25 12:13:37 UTC 2023


On Wed, 25 Oct 2023 10:57:52 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/serial/serialBlockOffsetTable.cpp line 131:
> 
>> 129:   if (offset_card != end_card) {
>> 130:     // Handling remaining cards.
>> 131:     size_t start_card_for_region = offset_card + 1;
> 
> Maybe `start_card_for/to_update` is a better name?

Obsolete given a definition of a "region".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16304#discussion_r1371644612


More information about the hotspot-gc-dev mailing list