RFR: 8318647: Serial: Refactor BlockOffsetTable [v3]

[Thomas Schatzl]

On Wed, 25 Oct 2023 14:01:55 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> The diff is too large; maybe it's better to read the new impl directly, which I believe is much easier to follow.
>> 
>> There is some duplication with G1's implementation, which should probably be dealt with in its own PR.
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

I would have renamed the classes as suggested as well when renaming the files; there does not seem to be much meaning to just renaming the files to me.

However assuming you will finish the renaming in an upcoming change anyway, I'll approve this.

src/hotspot/share/gc/serial/serialBlockOffsetTable.hpp line 111:

> 109: // how far back one must go to find the start of the chunk that includes the
> 110: // first word of the subregion.
> 111: class BlockOffsetTable {

The file has been renamed which is great, but the class is still called `BlockOffsetTable` without the prefix.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16304#pullrequestreview-1703590658
PR Review Comment: https://git.openjdk.org/jdk/pull/16304#discussion_r1375879808