RFR: 8315450: G1: Remove redundant adjustment to GCDrainStackTargetSize

Thomas Schatzl tschatzl at openjdk.org
Fri Sep 1 08:25:38 UTC 2023


On Thu, 31 Aug 2023 10:09:41 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple removing redundant check & write to an global VM flag.

This is a known (to me at least) "issue" that this code is redundant. However its presence does make sure that somebody thought about bounding `GCDrainStackTargetSize` to something sensible; what if somebody changes the default value of that option?
So I am impartial about this change.

More important could be that there should be a limit to users setting `GCDrainStackTargetSize` to something beyond `TASKQUEUE_SIZE`. Currently its value is silently overridden by internal ergonomics.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15510#issuecomment-1702363887


More information about the hotspot-gc-dev mailing list