RFR: 8316906 Clarify TLABWasteTargetPercent flag [v2]
Albert Mingkun Yang
ayang at openjdk.org
Tue Sep 26 11:56:13 UTC 2023
On Tue, 26 Sep 2023 09:06:12 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:
>> This flag is currently described as "Percentage of Eden that can be wasted". However, it does not address all kinds of waste. It specifically only controls the waste due to half-full TLABs at GC time. I propose to clarify this description, because it took me a lot of time to figure it out.
>
> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>
> More details, fix parenthesis
It seems questionable to assume that all tlabs retired before gc-pause are full and the one retired at gc-pause-start is half-full, but that's a problem of that flag; this PR looks good.
-------------
Marked as reviewed by ayang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15904#pullrequestreview-1644073775
More information about the hotspot-gc-dev
mailing list