RFR: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration [v6]

[Albert Mingkun Yang]

On Thu, 28 Sep 2023 15:22:46 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1CodeRootSet.cpp line 82:
>> 
>>> 80:     uintx get_hash() const;
>>> 81:     bool equals(G1CodeRootSetHashTableValue* value);
>>> 82:     bool is_dead(G1CodeRootSetHashTableValue* value) const { return false; }
>> 
>> I wonder if `(...)` works, since the arg in unused. (Inspired by `struct NOP` in conc-hashtable.)
>
> something is missing here. You probably mean something like:
> 
> ```     bool is_dead(G1CodeRootSetHashTableValue*) const```
> 
> We do not do that elsewhere either. We do not use `(...)` either elsewhere (in gc code at least), and I do not want to start this kind of discussion as part of this change.

I meant `bool is_dead(...) const { return false; }`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15811#discussion_r1340413820