RFR: 8329469: Generational ZGC: Move the methods forwarding_[index|find|insert] from zRelocate.cpp to ZForwarding [v2]

Stefan Karlsson stefank at openjdk.org
Tue Apr 2 15:36:10 UTC 2024


On Tue, 2 Apr 2024 13:33:54 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> src/hotspot/share/gc/z/zRelocate.cpp line 356:
>> 
>>> 354: 
>>> 355:   // Lookup forwarding
>>> 356:   zaddress to_addr = forwarding->find(from_addr, &cursor);
>> 
>> While looking at this, I now see that this could use the find overload that doesn't take a ZForwardingCursor. Could you update the code to do so?
>
> The `cursor` here can be used by the following `insert`. So it is good to keep it.

I agree. I missed that insert call in the diff.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18579#discussion_r1548120329


More information about the hotspot-gc-dev mailing list