RFR: 8329570: G1: Excessive is_obj_dead_cond calls in verification
Guoxiong Li
gli at openjdk.org
Wed Apr 3 11:22:09 UTC 2024
On Wed, 3 Apr 2024 11:15:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Sounds like a reasonable thing to do. I'll move that assert as well.
>
> You mean moving `assert(_containing_obj != nullptr, "must be");` from `do_oop_work`? I think it should stay there, as it verifies that someone called `set_containing_obj` before doing `do_oop_work`?
I think it is better to add a new one insteading of moving it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18595#discussion_r1549515919
More information about the hotspot-gc-dev
mailing list