RFR: 8329570: G1: Excessive is_obj_dead_cond calls in verification

[Aleksey Shipilev]

On Wed, 3 Apr 2024 11:37:19 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> I think it should be moved; the risk of misuse here is low.
>
>> I think it should be moved; the risk of misuse here is low.
> 
> If we move it, could/should we add some related comments in the class `G1VerifyLiveAndRemSetClosure` or the related methods?

I'd prefer to have a clear assert failure instead of SEGV. Maybe if we move the assert closer to its first use (`LiveChecker<T> live_check(this, _containing_obj, p, obj, _vo);`), the null-check would filter enough to gain the same perf improvement?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18595#discussion_r1549562069