RFR: 8329661: Refactor ScavengableNMethods::verify_unlisted_nmethods

[Stefan Karlsson]

On Thu, 4 Apr 2024 11:28:17 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple removing redundant verification.

OK. I understand the change now. I wonder if it would make sense to rename `verify_unlisted_nmethods` now that you removed the section that visited "unlisted" nmethods. The function now only verifies "unlisted" nmethods inside `verify_nmethod` (which doesn't have the "_unlisted_" infix). Could this be named `verify_nmethods` instead?

src/hotspot/share/gc/serial/serialHeap.cpp line 879:

> 877:     "Does not work if address is non-null and outside of the heap");
> 878:   return p < _young_gen->reserved().end() && p != nullptr;
> 879: }

I think the ifdefs should be removed as well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18621#pullrequestreview-1980045585
PR Review Comment: https://git.openjdk.org/jdk/pull/18621#discussion_r1551767027