RFR: 8329529: Serial: Move _saved_mark_word out of ContiguousSpace [v2]

Guoxiong Li gli at openjdk.org
Fri Apr 5 10:09:23 UTC 2024


On Fri, 5 Apr 2024 09:51:17 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Remove saved mark word of eden-space and from-space.
>>  - Merge branch 'master' into SAVED_MARK_WORD
>>  - Set saved mark word out of oop iteration.
>>  - JDK-8329529
>
> src/hotspot/share/gc/serial/defNewGeneration.hpp line 174:
> 
>> 172:   ContiguousSpace* to()   const           { return _to_space;   }
>> 173: 
>> 174:   // Access saved mark word
> 
> comment doesn't seem to add any value

Removed.

> src/hotspot/share/gc/serial/tenuredGeneration.hpp line 69:
> 
>> 67: 
>> 68:   TenuredSpace*       _the_space;       // Actual space holding objects
>> 69:   HeapWord*           _saved_mark_word; // Saved mark word
> 
> `// Saved mark word` seems unnecessary

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18603#discussion_r1553318671
PR Review Comment: https://git.openjdk.org/jdk/pull/18603#discussion_r1553318491


More information about the hotspot-gc-dev mailing list