RFR: 8329764: G1: Handle null references during verification first [v2]

[Thomas Schatzl]

On Fri, 5 Apr 2024 12:21:27 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> > > I integrated the simplest version of #18595 now. I still think it would be nice to clean away the assert(_containing_obj...) with my proposed changes. Should I do that? Or do you have some other plan for it?
> > 
> > 
> > I am good with moving the `assert` too (not sure if it is worth an extra change or adding it here); however this change, i.e. moving the condition, would improve performance beyond moving the assert as shown above.
> > The other changes from you about extracting the failure counter could be done as well - when refactoring this verification code the last time the extra 30 LOC or so did not seem worth to me, but the code is already fairly large.
> > There are no further plans from me to improve verification performance further, apart from maybe filing a CR to parallelize verification of large object arrays.
> > Does that answer your questions?
> 
> I had hoped for a more clear yes or no. :)

If unsure: Please move the assert and add the failure counter changes :) Would be nice to have.

Thomas

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18650#issuecomment-2039666637