RFR: 8329766: Serial: Refactor SerialBlockOffsetTable API

Ivan Walulya iwalulya at openjdk.org
Mon Apr 8 15:40:10 UTC 2024


On Fri, 5 Apr 2024 12:05:17 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Simple refactoring towards unifying BOT API between Serial and Parallel.
>
> src/hotspot/share/gc/serial/serialBlockOffsetTable.cpp line 80:
> 
>> 78: }
>> 79: 
>> 80: static void fill_range(uint8_t* start, uint8_t* end, uint8_t v) {
> 
> The name `offset` may be better to a simple letter `v`. But it is also OK now.

I suggest we write out the `v` as `value`, I don't see what we save by the abbreviation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18651#discussion_r1556052638


More information about the hotspot-gc-dev mailing list