RFR: 8329603: G1: Merge G1BlockOffsetTablePart into G1BlockOffsetTable [v3]

Guoxiong Li gli at openjdk.org
Mon Apr 8 16:14:18 UTC 2024


On Mon, 8 Apr 2024 15:16:48 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove unnecessary comments.
>>  - Fix indentation issue.
>
> src/hotspot/share/gc/g1/g1HeapRegion.inline.hpp line 107:
> 
>> 105: }
>> 106: 
>> 107: inline HeapWord* HeapRegion::block_start(const void* addr, HeapWord* const pb) const {
> 
> Can we move the assert `assert(addr >= _hr->bottom() && addr < _hr->top(), "invalid address");` here?

Moved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18634#discussion_r1556096013


More information about the hotspot-gc-dev mailing list