RFR: 8329858: G1: Make G1VerifyLiveAndRemSetClosure stateless [v2]

[Stefan Karlsson]

On Tue, 9 Apr 2024 06:56:20 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> In [JDK-8329570](https://bugs.openjdk.org/browse/JDK-8329570): 'G1: Excessive is_obj_dead_cond calls in verification' we moved the verification of the containing object so that it was done only once. We left the repeated null-check because of concerns that moving it would introduce the risk that someone in the future would miss calling `set_containing_obj` or calling it with a null object.
>> 
>> I propose that we restructure the code to make the closure's state const and remove the set_containing_obj function so that we can feel confident that we don't hit such a bug in the future.
>> 
>> The patch also combines the failures from verification of the oops with failures from checking the containing objects. I had a version that kept these two separate, but I don't see why we would want that. Tell me if you'd want me to reintroduce this separation.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18677#issuecomment-2045077931