RFR: 8329469: Generational ZGC: Move the methods forwarding_[index|find|insert] from zRelocate.cpp to ZForwarding [v2]

[Guoxiong Li]

On Tue, 9 Apr 2024 12:35:36 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Mark several methods as private. Reduce cursor.
>>  - Merge branch 'master' into MOVE_FORWARDING
>>  - Move methods about ZForwarding.
>
> src/hotspot/share/gc/z/zForwarding.hpp line 90:
> 
>> 88:   zaddress find(zoffset from_offset, ZForwardingCursor* cursor);
>> 89:   zoffset insert(uintptr_t from_index, zoffset to_offset, ZForwardingCursor* cursor);
>> 90:   zaddress insert(zoffset from_offset, zaddress to_addr, ZForwardingCursor* cursor);
> 
> Suggestion:
> 
>   uintptr_t index(zoffset from_offset);
> 
>   ZForwardingEntry find(uintptr_t from_index, ZForwardingCursor* cursor) const;
>   zaddress find(zoffset from_offset, ZForwardingCursor* cursor);
> 
>   zoffset insert(uintptr_t from_index, zoffset to_offset, ZForwardingCursor* cursor);
>   zaddress insert(zoffset from_offset, zaddress to_addr, ZForwardingCursor* cursor);

Fixed.

> src/hotspot/share/gc/z/zForwarding.hpp line 152:
> 
>> 150:   zaddress find(zaddress_unsafe from_addr, ZForwardingCursor* cursor);
>> 151:   zaddress find(zaddress_unsafe from_addr);
>> 152:   zaddress insert(zaddress from_addr, zaddress to_addr, ZForwardingCursor* cursor);
> 
> Suggestion:
> 
>   zaddress find(zaddress from_addr, ZForwardingCursor* cursor);
>   zaddress find(zaddress_unsafe from_addr, ZForwardingCursor* cursor);
>   zaddress find(zaddress_unsafe from_addr);
> 
>   zaddress insert(zaddress from_addr, zaddress to_addr, ZForwardingCursor* cursor);

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18579#discussion_r1557653435
PR Review Comment: https://git.openjdk.org/jdk/pull/18579#discussion_r1557653636