RFR: 8329764: G1: Handle null references during verification first [v3]

Thomas Schatzl tschatzl at openjdk.org
Tue Apr 9 15:14:23 UTC 2024


> Hi all,
> 
>   please review this change that suggests to move the null reference check in object iteration during heap verification first.
> 
> The reason is as stated, since null references are fairly common (not only in that test mentioned in https://bugs.openjdk.org/browse/JDK-8329314), it may make sense to put it first. Also, null references never fail anyway (and verification failure is supposed to be uncommon).
> 
> Improves total runtime of that test case from 3s (~3.9s cpu time) to 2.2s (~3.1s cpu time).
> 
> If you think it makes the code too ugly, I will retract it.
> 
> Testing: gha, local testing.

Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - Merge branch 'master' into submit/8329764-verification-null-refs-first
 - 8329764
 - 8329570: G1: Excessive is_obj_dead_cond calls in verification

-------------

Changes: https://git.openjdk.org/jdk/pull/18650/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18650&range=02
  Stats: 8 lines in 1 file changed: 5 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18650.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18650/head:pull/18650

PR: https://git.openjdk.org/jdk/pull/18650


More information about the hotspot-gc-dev mailing list