RFR: 8329767: G1: Move G1BlockOffsetTable::set_for_starts_humongous to HeapRegion [v2]

Ivan Walulya iwalulya at openjdk.org
Wed Apr 10 08:01:00 UTC 2024


On Wed, 10 Apr 2024 04:12:25 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch moves the method `G1BlockOffsetTable::set_for_starts_humongous` into `HeapRegion::set_starts_humongous` and marks `G1BlockOffsetTable::update_for_block(HeapWord* blk_start, size_t size)` as public (because it delegates to another public method which has the same name).
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove method update_for_block.

LGTM!

-------------

Marked as reviewed by iwalulya (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18701#pullrequestreview-1991033122


More information about the hotspot-gc-dev mailing list