RFR: 8330003: Serial: Move the logic of FastEvacuateFollowersClosure to SerialHeap [v2]

Guoxiong Li gli at openjdk.org
Wed Apr 10 14:28:15 UTC 2024


On Wed, 10 Apr 2024 14:04:59 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Mark two methods as inline.
>
> src/hotspot/share/gc/serial/serialHeap.cpp line 768:
> 
>> 766:                                      OldGenScanClosure* old_cl) {
>> 767:   do {
>> 768:     oop_since_save_marks_iterate(young_cl, old_cl);
> 
> This method can probably be inlined; I don't see any other usages.

Inlined just now.

> I meant physically copy the body of SerialHeap::oop_since_save_marks_iterate here.

OK.

> I inlined both oop_since_save_marks_iterate and scan_evacuated_objs. But it seems that you only want to inline oop_since_save_marks_iterate?

What do you think about that I marked `scan_evacuated_objs` as `inline`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18725#discussion_r1559538579
PR Review Comment: https://git.openjdk.org/jdk/pull/18725#discussion_r1559547101


More information about the hotspot-gc-dev mailing list