RFR: 8330003: Serial: Move the logic of FastEvacuateFollowersClosure to SerialHeap [v2]

[Albert Mingkun Yang]

On Wed, 10 Apr 2024 14:25:29 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> src/hotspot/share/gc/serial/serialHeap.inline.hpp line 43:
>> 
>>> 41:                                             OldGenScanClosure* old_cl) {
>>> 42:   do {
>>> 43:     oop_since_save_marks_iterate(young_cl, old_cl);
>> 
>> I meant physically copy the body of `SerialHeap::oop_since_save_marks_iterate` here.
>
>> I meant physically copy the body of SerialHeap::oop_since_save_marks_iterate here.
> 
> OK.
> 
>> I inlined both oop_since_save_marks_iterate and scan_evacuated_objs. But it seems that you only want to inline oop_since_save_marks_iterate?
> 
> What do you think about that I marked `scan_evacuated_objs` as `inline`?

No need for `scan_evacuated_objs` to be `inline`, I believe. The expensive part is the loop.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18725#discussion_r1559553516