RFR: 8329658: Serial: Refactor ContiguousSpace::_next_compaction_space [v5]

Albert Mingkun Yang ayang at openjdk.org
Fri Apr 12 08:07:45 UTC 2024


On Fri, 12 Apr 2024 08:02:52 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch removes the uncessary `ContiguousSpace::_next_compaction_space` and uses `DefNewGeneration::_promotion_failed` instead.
>> 
>> The tests `make test-tier1_gc` passed locally.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Use a local variable.
>  - Merge branch 'master' into NEXT_COMPACT_SPACE
>  - Polish
>  - Merge branch 'master' into NEXT_COMPACT_SPACE
>    
>    # Conflicts:
>    #	src/hotspot/share/gc/shared/space.hpp
>  - Make promotion_failed as private.
>  - Judge whether to-space is empty.
>  - JDK-8329658

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18666#pullrequestreview-1996144990


More information about the hotspot-gc-dev mailing list