RFR: 8329771: G1: Refactor G1BlockOffsetTable::verify [v2]

Thomas Schatzl tschatzl at openjdk.org
Fri Apr 12 11:19:44 UTC 2024


On Fri, 12 Apr 2024 10:23:12 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch verifies the BOT after writing the BOT and changes the method name for consistence, just like `SerialBlockOffsetTable::verify_for_block` and `ObjectStartArray::verify_for_block`.
>> 
>> The test `make test-tier1_gc` passed locally. Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Extract a common method.
>  - Move into ASSERT block.
>  - Merge branch 'master' into REFACTOR_VERIFY
>  - JDK-8329771

Marked as reviewed by tschatzl (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18711#pullrequestreview-1996511781


More information about the hotspot-gc-dev mailing list