RFR: 8330145: Serial: Refactor SerialHeap::scan_evacuated_objs

Guoxiong Li gli at openjdk.org
Fri Apr 12 13:48:41 UTC 2024


On Fri, 12 Apr 2024 08:19:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple refactoring to extract oop-scanning logic from generation.

Looks good. One question.

src/hotspot/share/gc/serial/serialHeap.cpp line 797:

> 795:       break;
> 796:     }
> 797:   } while (true);

Why not keeping the previous ` while (!no_allocs_since_save_marks())`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18750#pullrequestreview-1997031804
PR Review Comment: https://git.openjdk.org/jdk/pull/18750#discussion_r1562551295


More information about the hotspot-gc-dev mailing list