RFR: 8330145: Serial: Refactor SerialHeap::scan_evacuated_objs

[Guoxiong Li]

On Fri, 12 Apr 2024 13:51:17 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/serial/serialHeap.cpp line 797:
>> 
>>> 795:       break;
>>> 796:     }
>>> 797:   } while (true);
>> 
>> Why not keeping the previous ` while (!no_allocs_since_save_marks())`?
>
> The old-gen-iteration should have ensured no alloc in old-gen, so only young-gen requires rechecking.

Both new-gen `YoungGenScanClosure` and old -gen `OldGenScanClosure` use the methods `ScavengeHelper::try_scavenge` and `DefNewGeneration::copy_to_survivor_space` to evacuate objects. The `DefNewGeneration::copy_to_survivor_space` may promote objects to old-gen. Do I miss anything or misunderstand it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18750#discussion_r1562602588