RFR: 8328792: Parallel: Refactor PSParallelCompact::summary_phase [v9]
Thomas Schatzl
tschatzl at openjdk.org
Mon Apr 15 13:15:45 UTC 2024
On Thu, 11 Apr 2024 09:34:18 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> `_maximum_compaction_gc_num` is on the same abstraction level as the checking denoted as "JVM flags". Separating them will probably make code harder to follow.
>
> Not sure I agree, but it is a minor issue, not a blocker.
>
> LGTM!
I also somewhat agree that changing `_maximum_compaction_gc_num` seems unexpected.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18451#discussion_r1565773092
More information about the hotspot-gc-dev
mailing list