Integrated: 8329764: G1: Handle null references during verification first

[Thomas Schatzl]

On Fri, 5 Apr 2024 11:09:17 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this change that suggests to move the null reference check in object iteration during heap verification first.
> 
> The reason is as stated, since null references are fairly common (not only in that test mentioned in https://bugs.openjdk.org/browse/JDK-8329314), it may make sense to put it first. Also, null references never fail anyway (and verification failure is supposed to be uncommon).
> 
> Improves total runtime of that test case from 3s (~3.9s cpu time) to 2.2s (~3.1s cpu time).
> 
> If you think it makes the code too ugly, I will retract it.
> 
> Testing: gha, local testing.

This pull request has now been integrated.

Changeset: a3fecdb2
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a3fecdb2f417bd32e528f907bc293cc494746955
Stats:     8 lines in 1 file changed: 5 ins; 1 del; 2 mod

8329764: G1: Handle null references during verification first

Reviewed-by: stefank, iwalulya

-------------

PR: https://git.openjdk.org/jdk/pull/18650